search

toddams / RazorLight

Template engine based on Microsoft's Razor parsing engine for .NET Core
Apache License 2.0
1.5k stars 259 forks source link

Fix 361 #432

Closed Aledever4i closed 2 years ago

Aledever4i commented 3 years ago

Hello, I'm very tired of your chatting about core runtime ( #361 ) as result did this commit.

Please check it and give your opinion.

With sincerely, Igor Sukhov

jzabroski commented 3 years ago

Hi Igor,

Apologies for not getting to this sooner - I caught COVID and it has been a long recovery.

Can you explain why this fixes the issue?

Aledever4i commented 3 years ago

I want to help you maintain this framework, and this is one step for release 2.0 version. We have #360 issue about <FrameworkReference Include="Microsoft.AspNetCore.App" />, because if you change it to <PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="2.2.0" />, you'll take error from compiler (CS1061 error).

What i did is separete tests for web and desktop (base logic). Web uses Microsoft.NET.Sdk.Web , desktop other library.

jzabroski commented 2 years ago

Closing this, as #467 effectively sidesteps this problem entirely by dropping .NET Framework support. CC @toddams