search

toddams / RazorLight

Template engine based on Microsoft's Razor parsing engine for .NET Core
Apache License 2.0
1.5k stars 259 forks source link

Added support for .NET 6 #466

Closed leighmetzroth closed 2 years ago

leighmetzroth commented 2 years ago

This is to fix issue #460

Changes are as per @jacodv's branch leaving out some of the extraneous code and the test project. It also includes the workaround for ReSharper having issues with running the tests as I also run into it with the latest production version.

jacodv commented 2 years ago

@leighmetzroth - Well done and thank you!

jzabroski commented 2 years ago

The build workflow needs to be updated to support .net 6.

jzabroski commented 2 years ago

@leighmetzroth Can you please rebase the PR. I tried to set-up automatic rebasing but since this is technically still @toddams repository, I cant add a personal access token to make the rebase work correctly.

toddams commented 2 years ago

@jzabroski I can add whatever is needed, just ask ;)

jzabroski commented 2 years ago

@toddams See this https://www.jessesquires.com/blog/2021/10/17/github-actions-workflows-for-automatic-rebasing-and-merging/ which I used to create the rebase workflow. But it requires a personal access token.

leighmetzroth commented 2 years ago

I assume there is nothing else I need to do for now, you guys are sorting out the build workflow side of it?

leighmetzroth commented 2 years ago

I've done the rebase and pushed it anyway

jzabroski commented 2 years ago

I assume there is nothing else I need to do for now, you guys are sorting out the build workflow side of it?

I am trying to figure out exactly how GitHub Actions works. I was assuming it would build any PR off the workflow specified in the main branch, but it seems to be taking it from the head commit of the PR instead. This is something I never really noticed before

leighmetzroth commented 2 years ago

Would it be quicker and easier for me to close this PR and re-create?

jzabroski commented 2 years ago

Yes, that would probably be best. Rebasing is the same thing. But might be cleaner to re-do the PR. Its a feature gap in how GitHub Actions and PRs work that there is no easy way to rebase (if there is, I dont know it). GitHub lets you rebase the PR to the target branch, which is not what we want I think. See screenshot:

image