search

toddaustin07 / webrequestor

Web Requestor Edge Driver
Apache License 2.0
21 stars 8 forks source link

Fix timeouts #1

Closed zelch closed 2 years ago

zelch commented 2 years ago

On current firmware releases, at least v43.0004, the web requestor currently doesn't work.

https://community.smartthings.com/t/smartthings-edge-issue-with-http-requests-in-lan-drivers/242631/46 goes into this in some depth.

(It's possible that the current repository is out of date, and for some reason my hub never received a new version of the driver.)

toddaustin07 commented 2 years ago

Hello! My apologies for not responding earlier. This one got by me. Yes, I've been bad about keeping github updated. I had already updated the driver to use cosck.asyncify. I had done that pretty much immediately when the firmware update came out that required it back in June.

But tell me more about your need for 15 second timeout? For anything on your local LAN I wouldn't think that would be needed, so are you doing internet requests using a proxy or my edge bridge server? I think 15 seconds would be fairly irritating for most other users, but maybe a better way to meet your requirements is by providing a device settings option to set the timeout. What do you think?

zelch commented 2 years ago

15 seconds is definitely higher than I need, but 3 is well within the 'normal delays could easily trigger this' range.

Mostly because of the mixture of slow hardware, TLS handshakes, sometimes congested wifi, and sleeping in the code on the Pi at the other end of things (there is a reverse proxy involved, but it's all local) while toggling the relay driving the garage door openers.

toddaustin07 commented 2 years ago

A timeout option is now included in the device Settings.