search

toddfarmer / arrow-migration

0 stars 1 forks source link

[C++] More graceful solution for handling non-zero offsets on inputs and outputs in compute library #1456

Closed toddfarmer closed 6 years ago

toddfarmer commented 7 years ago

Note: This issue was originally created as ARROW-1524. Please see the migration documentation for further details.

Original Issue Description:

Currently we must remember to shift by the offset. We should add some inline utility functions to centralize this logic.

toddfarmer commented 6 years ago

Note: Comment by Wes McKinney (wesm): This is quite urgent as many of the cast kernel implementations do not properly account for the offset, and so if used on sliced arrays at present will yield incorrect results

toddfarmer commented 6 years ago

Note: Comment by Wes McKinney (wesm): Resolved in https://github.com/apache/arrow/commit/54d5c81af0a9cbc6ea551922c795728cd43bd86c