search

toddjordan / ember-cli-dynamic-forms

An Ember addon for creating dynamic forms
http://toddjordan.github.io/ember-cli-dynamic-forms/
MIT License
35 stars 16 forks source link

changeAction is behind when changing 'select' fields #39

Closed maprules1000 closed 8 years ago

maprules1000 commented 8 years ago

changeAction is currently only called on 'click' and 'keyup' which does not fit the select field. When the 'select' field is clicked the action is called and the drop down is activated, but when the new option is selected the action is not called.

Could the 'change' action be used to trigger the changeAction function, or is there a reason only 'click' and 'keyup' are supported? (This is all in dynamic-form.js under _buildPostRender()).

I can submit a quick pr for this change too.

toddjordan commented 8 years ago

Hi @maprules1000 sounds reasonable. Would love a PR ❤️