search

toddjordan / ember-cli-dynamic-forms

An Ember addon for creating dynamic forms
http://toddjordan.github.io/ember-cli-dynamic-forms/
MIT License
35 stars 16 forks source link

Removing getOwner Polyfill since is deprecated since Ember 2.3 #52

Closed supersabillon closed 7 years ago

supersabillon commented 7 years ago

When trying to test this addon I ran into an issue of the ember-getowner-polyfill module not being found. This polyfill is deprecated so here's a pr removing it from package.json and updating dynamic-forms.js.

cheers

toddjordan commented 7 years ago

Thanks so much @supersabillon. I guess the question is anyone using this addon pre-getOwner. That's the reason the proposed fix is breaking CI (ember try on 1.13). I'm willing to cut the next release and say that this no longer supports pre-2.3, but will need to remove 1.13 from ember-try.

toddjordan commented 7 years ago

Going ahead and ending 1.13 support (removed from travis). Merging this and will cut a new release.

Thanks @supersabillon !