Add "Remove Session Cookies" option (feature request)

[GoogleCodeExporter]

First, thanks for a great extension!

I work on a number of sites where it would be nice to be able to quickly
simulate a new browser session by purging all session cookies but leaving
all permanent cookies. Right now, the only options are to remove all
cookies (regardless of their lifetime duration) or to click on cookies
one-at-a-time and then choose "delete." One sites where there are a number
of cookies or where there needs to be a series of repeated tests, the
one-by-one approach quickly becomes cumbersome.

Please consider adding a "remove session cookies" option to complement the
current "remove cookies." I don't know at the moment if there might be a
need to selectively remove multiple cookies based on some other criteria
(path, perhaps?), but you may want to consider that in your design if you
decide to implement this request.

Thank you for your time.
--James

Original issue reported on code.google.com by same...@gmail.com on 5 Feb 2010 at 4:52

[GoogleCodeExporter]

Here is a patch:

Original comment by same...@gmail.com on 5 Mar 2010 at 3:19

Attachments:

• james.patch

[GoogleCodeExporter]

Slightly revised "if" statement patch. I've simplified or complicated the main 
"if"
statement, depending on your point of view.

This is a complete patch (not an additional patch), which can use instead of 
previous
patch, depending on coding preference.

Original comment by same...@gmail.com on 5 Mar 2010 at 3:32

Attachments:

• james2.patch

[GoogleCodeExporter]

Thanks for the patch!
Committed at R272
Please verify

I have made some changes:

- I don't want to append new strings into the .dtd anymore since if these 
strings are
missing in other locales (and it takes a time to get all strings translated), 
the XUL
overlay fails to load. Note that there is no way to script DTD entities. The 
idea
here is to move all .dtd strings to .properties file (I am planning to do it 
soon).

- Some comments appended

- The longer, but easier to understand condition (in onRemoveAllShared) used.

- Tabs replaced by spaces (also Firebug's source code rule)

- Some trailing white-spaces removed (minor, but I just took the chance to do 
it).

- I have created another confirmation dialog for "Remove Session Cookies" that
properly says "Do you want to remove all session cookies in the list?". It was
confusing when I have chosen to "Remove Session Cookies" (only) and the dialog 
said
"Do you want to remove all cookies in the list?". I don't know if this is the 
best
(from the user point of view) but this means that there are two different
confirmation dialogs and the user needs to check two checkboxes (in both 
dialogs) to
get rid of both of them. I would say, we'll see the feedback...

- I have updated the about dialog with new contributor "James Olsen". Please 
let me
know if this is ok for you :-)

This feature should be in Firecookie 1.0.3

Thanks again for your help!
Honza

Original comment by odva...@gmail.com on 8 Mar 2010 at 9:33

• Changed state: Commit

[GoogleCodeExporter]

Manual test case:
http://www.janodvarko.cz/firecookie/tests/issue59/issue59.php

Honza

Original comment by odva...@gmail.com on 8 Mar 2010 at 9:44

[GoogleCodeExporter]

I meant to create a new dialog but decided I would ask you about it...and then 
forgot :)

I've made a mental note of the other things you've said for future patches. 
Thank you
for your patience while I learn how to be a open-source contributor. I'll get 
the
hang of it soon :)

And lastly, thank you for offering to include me on the contributor list. My 
name
would be great :D

Sorry for all the smilies. I guess I'm just pretty upbeat right now. 

--James

Original comment by same...@gmail.com on 8 Mar 2010 at 2:00

[GoogleCodeExporter]

This issue should be fixed in Firecookie 1.1b9
http://www.softwareishard.com/firecookie/archive/

Please verify
Honza

Original comment by odva...@gmail.com on 19 Oct 2010 at 9:12

• Changed state: Fixed