Swap English text to symbolic emojis

toddmedema / electrify

Take Charge of the Power Market

http://electrifygame.com

MIT License

6 stars 2 forks source link

Swap English text to symbolic emojis #112

Closed n-hebert closed 2 months ago

n-hebert commented 2 months ago

Contributes to the vision of #52

WDYT @toddmedema ?

The gutter may need its margins/buffers reworked to fit these, but I really like the immediate understanding of the emojis.

toddmedema commented 2 months ago

I like this direction! Two thoughts:

Are you able to increase the font size? The icons seem a bit small
The icons themselves are a bit indistinct (what is a sunset but a sunrise in reverse?) - I think a good way of clarifying this would be to add a ☀️ in the middle, at noon. Think you're up for that challenge? Looks like noon is always symmetrically between rise and set, so rather than having to calculate the full astronomical noon time, you could take a shortcut and just do sunrise + (sunset - sunrise) / 2

n-hebert commented 2 months ago

Sounds good! I'll take a look at getting those things going and come back with any Q's

toddmedema commented 2 months ago

@n-hebert oddly, I just pulled this down and it's rendering fine for me -

Maybe try pushing your latest changes and I can test again, and maybe we both test in a couple browsers to see if it's a browser-specific issue?

n-hebert commented 2 months ago

Ah! It's a firefox bug! Chromium doesn't have it

toddmedema commented 2 months ago

Glad we found that out! Since only 3% of people use firefox and it's only a cosmetic issue, I think this is good enough for this project. Thank you for the contribution! What's next? 😁