search

toddmohney / json-api

Haskell Implementation of the JSON-API specification
http://hackage.haskell.org/package/json-api
MIT License
35 stars 14 forks source link

Supportpagination #35

Closed shirren closed 5 years ago

shirren commented 5 years ago

Looking good! trophy

Thanks @toddmohney . PR is now ready for review, I wanted some feedback from a colleague of mine (@ben-barnes ). By the way, do you know why CI is stuck?

shirren commented 5 years ago

@toddmohney I am sure you are quite busy. But I was wondering if you had time to merge and publish the new version of the package by next week? Be great if we could start using the paging next week. Thanks in advance.

toddmohney commented 5 years ago

@shirren I plan on getting this merged and released this weekend. Thanks for your contribution!

If you want to put this to work before it gets released, you can configure the extra-deps section of your stack.yaml file to reference a Git commit as described here

shirren commented 5 years ago

@shirren I plan on getting this merged and released this weekend. Thanks for your contribution!

If you want to put this to work before it gets released, you can configure the extra-deps section of your stack.yaml file to reference a Git commit as described here

Thanks for the tip @toddmohney. Also thanks for taking the time out to merge on your weekend. We've also raised another issue. Keen to get your thoughts on it. Issue #34.

shirren commented 5 years ago

@toddmohney noticed that the PR has not been merged yet? Can I help do this?

toddmohney commented 5 years ago

@shirren thanks for you contribution and your patience. I've merged the PR and push the latest changes to Hackage https://hackage.haskell.org/package/json-api. The documentation is building now. I'll keep an eye on it an make sure it succeeds.

Cheers!