toddmohney / json-api

Haskell Implementation of the JSON-API specification
http://hackage.haskell.org/package/json-api
MIT License
35 stars 14 forks source link

Support for source in error #37

Closed shirren closed 5 years ago

shirren commented 5 years ago

@toddmohney I've added support for the source attribute in errors.

shirren commented 5 years ago

@toddmohney will you kindly have some time over the coming days to provide feedback if not merge this PR? Thanks in advance.

toddmohney commented 5 years ago

Yep. I’m out of town at the moment. I plan on taking a look on Tuesday.

On Sat, Jul 20, 2019 at 20:13 Shirren Premaratne notifications@github.com wrote:

@toddmohney https://github.com/toddmohney will you kindly have some time over the coming days to provide feedback if not merge this PR? Thanks in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/toddmohney/json-api/pull/37?email_source=notifications&email_token=AADB3BZ6D2T2SXWKTL3TZEDQAOSZNA5CNFSM4IEPMIN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NYHZQ#issuecomment-513508326, or mute the thread https://github.com/notifications/unsubscribe-auth/AADB3B43WUMI5NOGOMJILQTQAOSZNANCNFSM4IEPMINQ .

shirren commented 5 years ago

Yep. I’m out of town at the moment. I plan on taking a look on Tuesday. On Sat, Jul 20, 2019 at 20:13 Shirren Premaratne @.***> wrote: @toddmohney https://github.com/toddmohney will you kindly have some time over the coming days to provide feedback if not merge this PR? Thanks in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37?email_source=notifications&email_token=AADB3BZ6D2T2SXWKTL3TZEDQAOSZNA5CNFSM4IEPMIN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NYHZQ#issuecomment-513508326>, or mute the thread https://github.com/notifications/unsubscribe-auth/AADB3B43WUMI5NOGOMJILQTQAOSZNANCNFSM4IEPMINQ .

Thanks @toddmohney

shirren commented 5 years ago

@toddmohney are you back from your holiday?

toddmohney commented 5 years ago

@shirren Deployed! Thanks again for your contribution. https://hackage.haskell.org/package/json-api-0.1.4.0