search

toddmotto / angular-component

Fully featured .component() polyfill for Angular v1.3+
https://toddmotto.com
Other
191 stars 30 forks source link

feat: Add 'isFirstChange' function to $onChanges hook changes object #34

Closed bmcalister closed 8 years ago

bmcalister commented 8 years ago
toddmotto commented 8 years ago

Hey Brian! I'm actually working on a separate branch to address a few issues, including this features, tests, and ensuring things are 100% feature complete. The isFirstChange is located here, and it's taken from the actual Angular source code: https://github.com/toddmotto/angular-component/blob/es6-and-tests/src/angular-component.js#L25-L31

bmcalister commented 8 years ago

oh I see, thanks for the heads-up!

toddmotto commented 8 years ago

If you've got some time to help get the features fully working, lemme know :) there's a test currently failing on the branch that I need to look at. :)

bmcalister commented 8 years ago

yep, are you referring to this: https://github.com/toddmotto/angular-component/blob/es6-and-tests/src/angular-component.js#L155-L167 ?

toddmotto commented 8 years ago

Partly that, there is an issue currently which fails a test to do with the $digest loop. It's to do with the queueing situation that Angular uses internally. But yeah, there's a bit of work that needs doing on the new branch if you're open to helping out! 💃