Bugfix $on init trigger before on way binding

toddmotto / angular-component

Fully featured .component() polyfill for Angular v1.3+

https://toddmotto.com

Other

191 stars 29 forks source link

Bugfix $on init trigger before on way binding #39

Closed strokyl closed 6 years ago

strokyl commented 7 years ago

Contrary to what specify angular 1.5 documentation, when using angular 1.3 with this poly-fill, $onInit is called before one way binding are done. This is very annoying because this force to place initialisation code on $onChanges and to check initialisation has not been done yet.

I could not find the unit-test file mentioned in the contribution part of the README.

807811b0-1373-11e5-b60b-1697f925ec7b commented 7 years ago

chamerling commented 7 years ago

Hi @toddmotto,

Any chance to see this PR merged?

Thx a lot

strokyl commented 7 years ago

The thing is that he already fix this bug but on the following branch:

https://github.com/toddmotto/angular-component/tree/es6-and-tests So the question is when does this branch is going to be merge/become the new master. If this will be in a long time, it would be great to merge my PR in the meanwhile.

jeroenroumen commented 6 years ago

Hey @toddmotto

Would you consider merging this PR request?

Thanks ;)

lbickston-rgi commented 6 years ago

@toddmotto would you consider bumping the version?