search

toddmotto / angular-component

Fully featured .component() polyfill for Angular v1.3+
https://toddmotto.com
Other
191 stars 30 forks source link

Short circuit check for component definition #5

Closed cary-smith closed 8 years ago

cary-smith commented 8 years ago

We have a directive library that supports multiple AngularJS versions (1.3+). We would like to include your code without worrying about overwriting angular 1.5's implementation by accident when people upgrade their angular version.

toddmotto commented 8 years ago

Added this manually (https://github.com/toddmotto/angular-component/commit/47d5dcced5be2e8f30095dfdbfde550d3cc6ac1a) in with another update in 0.0.2 release, easier as the gulp task wasn't run to generate necessary /dist files. Thanks for pointing this out and contributing!

cary-smith commented 8 years ago

Thanks for adding it and thank you for making the library in the first place! This allows us to upgrade the library ahead of the point we would drop angular 1.4 support so we can get ready for 2. We were initially cloning and modifying your code, this will make it far easier to use wholesale.

Thanks again!

On Sat, Jan 9, 2016 at 11:09 AM, Todd Motto notifications@github.com wrote:

Added this manually (47d5dcc https://github.com/toddmotto/angular-component/commit/47d5dcced5be2e8f30095dfdbfde550d3cc6ac1a) in with another update in 0.0.2 release, easier as the gulp task wasn't run to generate necessary /dist files. Thanks for pointing this out and contributing!

— Reply to this email directly or view it on GitHub https://github.com/toddmotto/angular-component/pull/5#issuecomment-170260416 .