search

toddmotto / angularjs-styleguide

AngularJS styleguide for teams
https://ultimateangular.com
5.96k stars 700 forks source link

added missing argument in autofocus directive Class #118

Closed adiman9 closed 8 years ago

adiman9 commented 8 years ago

I spotted that the constructor in the Class for the autofocus directive was missing the injected $timeout. See the below image for context.

selection_001

I went ahead and made the change.

floriangosse commented 8 years ago

Thank you!

I notice right now that $timeout is not accessible in the link method because it is not assigned to a property of the object. If you have time it would be nice if you could add this. :)

toddmotto commented 8 years ago

Was literally about to post that this.$timeout = $timeout; needs adding in the constructor and then this.$timeout(...) inside link() {...} :)

adiman9 commented 8 years ago

Yes! I had missed that. I will add and update now

adiman9 commented 8 years ago

Done. Is there anything else I have missed?

toddmotto commented 8 years ago

Don't think so, if you have 30seconds to paste the same code inside the translated files (i18n folder) that'd be amazing! :)

adiman9 commented 8 years ago

Sure. Will do now

adiman9 commented 8 years ago

done

toddmotto commented 8 years ago

Perfect, thanks so much for the help :)!