search

toddmotto / angularjs-styleguide

AngularJS styleguide for teams
https://ultimateangular.com
5.96k stars 700 forks source link

Possible code mistake. Clarification needed. #120

Closed adiman9 closed 8 years ago

adiman9 commented 8 years ago

I think there is a mistake in the code snippet for the stateless component. I beleive the constructor needs this.EventEmitter = EventEmitter and then this.EventEmitter({ todo: this.todo}); inside the onSubmit method.

I am pretty sure this is a mistake, if so, I can submit a PR. Just wanted clarification that this is in incorrect.

selection_001

toddmotto commented 8 years ago

Ah yes that's an error. Too much TypeScript. PR would be great (plz don't forget the i18n files - need a way to automate this still).

@toddmotto

On 7 Sep 2016, at 00:09, Adrian Henry notifications@github.com wrote:

I think there is a mistake in the code snippet for the stateless component. I beleive the constructor needs this.EventEmitter = EventEmitter and then this.EventEmitter({ todo: this.todo}); inside the onSubmit method.

I am pretty sure this is a mistake, if so, I can submit a PR. Just wanted clarification that this is in incorrect.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

adiman9 commented 8 years ago

I have created the pull request. Included the i18n files too.