Closed laskoviymishka closed 8 years ago
Hey @laskoviymishka ! So, we made a few edits to the current styleguide. Essentially dropping *.controller.js
and adding it as an ES6 class
on the controller:
props, would you be able to grab the latest changes please and jig things around to fit? :) would love to merge this!
@toddmotto sure, I love this part. But would you mind if I recommend to use some decorators for this instead of old way? Inside regular guide there will be code pretty much same as es6 version, but in TS there is a lot of awesomeness that comes from decorators world (like this one https://github.com/MikeRyan52/angular-decorators or https://github.com/ngUpgraders/ng-forward or https://github.com/ngParty/ng-metadata). I could suggest to use them if you don't mind.
For the guide, as "vanilla Angular" as possible, however we can add a better "Potential recommendations" I think, citing something like ngMetadata
and ngForward
etc. :)
@toddmotto well vanilla
angular totally make sense. Let skip this part to later one :)
Hey, sorry for the delay with checking this - is it reviewable now? :)
yep
This is amazing - thank you so much! :)
Add specific folder and initial
en-US
version of a document. After initial doc merging addingi18n
folder to it would be much easier.Closes #69