we need to scrutinize every occurrence of .eq(...) in the database query system - Githubissues

toddobryan / schoolbox

Everything a school needs in one easy package. (Eventually.)

0 stars 0 forks source link

we need to scrutinize every occurrence of .eq(...) in the database query system #36

Open toddobryan opened 10 years ago

toddobryan commented 10 years ago

Checking if two DB objects are eq to each other is not safe. We should add a variable and check that the ids are equal, just to be sure nothing weird happens.

Justin00892 commented 10 years ago

Files that contain .eq(...) and need to be fixed.

(Justin) app/controllers/

[x] Assignments.scala 1 instance
[x] Books.scala 33 instances
[x] Conferences.scala 46 instances
[x] Grades.scala 1 instance
[x] Locker.scala 2 instances

app/models/

[x] assignments/Task.scala 1 instance
[x] blogs/Blog.scala 3 instances
[x] books/Copy.scala 11 instances
[x] books/LabelQueueSet.scala 1 instance
[x] books/PurchaseGroup.scala 5 instances
[x] books/Title.scala 19 instances
[x] conferences/Event.scala 3 instances
[x] conferences/Session.scala 1 instance
[ ] conferences/Slot.scala 3 instances
[x] conferences/TeacherActivation.scala 5 instances
[x] grades/Announcement.scala 1 instance
[x] grades/Assignment.scala 5 instances
[x] grades/Category.scala 1 instance
[x] lockers/Locker.scala 6 instances
[x] mastery/Question.scala 1 instance
[x] mastery/Quiz.scala 1 instance
[x] mastery/QuizSection.scala 1 instance

modules/courses

[x] app/config/courses/SendActivation.scala 5 instances
[x] app/controllers/courses/App.scala 11 instances
[x] app/models/courses/AcademicYear.scala 1 instance
[x] app/models/courses/Course.scala 1 instance
[x] app/models/courses/Department.scala 1 instance
[x] app/models/courses/Guardian.scala 6 instances
[x] app/models/courses/Period.scala 1 instance
[x] app/models/courses/Room.scala 1 instance
[x] app/models/courses/Section.scala 8 instances
[x] app/models/courses/Student.scala 15 instances
[x] app/models/courses/Teacher.scala 14 instances
[x] app/models/courses/Term.scala 1 instance

(Justin) modules/users

[x] app/controllers/users/App.scala 1 instance
[x] app/models/users/Activation.scala 2 instances
[x] app/models/users/Group.scala 1 instance
[x] app/models/users/Permission.scala 2 instances
[x] app/models/users/Role.scala 1 instance
[x] app/models/users/User.scala 4 instances
[x] app/models/users/Visit.scala 1 instance

(Justin) test/models

[x] ManualData.scala 21 instances

249 total instances 0 instances fixed 249 unscrutinized instances remaining

Please tell me when an instance has been looked at so I can update this list