search

toddr / Razor2-Client-Agent

Mirror sourceforge perl project razor. We now consider the parent project to be dead
http://razor.sourceforge.net/
Artistic License 2.0
4 stars 6 forks source link

Use Digest::SHA instead of Digest::SHA1 #11

Open robert-scheck opened 2 years ago

robert-scheck commented 2 years ago

Switch from Digest::SHA1 to Digest::SHA, because: Digest::SHA is a bit faster than Digest::SHA1, Digest::SHA1 has been removed from some Linux distributions, Digest::SHA is a core library (as of Perl >= 5.10.0) and Digest::SHA1 is not (and never will be). See also:

Original author: Warren Togami (wtogami@redhat.com)

mss commented 2 years ago

A slightly simpler patch is used in Debian as well: https://salsa.debian.org/debian/razor/-/blob/debian/1%252.85-7/debian/patches/use-Digest-SHA.patch

robert-scheck commented 2 years ago

A slightly simpler patch is used in Debian as well: https://salsa.debian.org/debian/razor/-/blob/debian/1%252.85-7/debian/patches/use-Digest-SHA.patch

Yes, however the Debian patch does not provide any backwards compatibility, which may or may not be desired by upstream.

mss commented 2 years ago

A slightly simpler patch is used in Debian as well: https://salsa.debian.org/debian/razor/-/blob/debian/1%252.85-7/debian/patches/use-Digest-SHA.patch

Yes, however the Debian patch does not provide any backwards compatibility, which may or may not be desired by upstream.

Indeed, I just ran into this while hacking on #13 and wanted to add this data point that most people probably use this change in some way already.