Possible bug in Razor2-Client-Agent-2.84

toddr commented 7 years ago

From @gonzus

When trying to compile and install this package, we ended up with a weird looking directory:

$ ls man/man1 man1/ man1 ^Iblib/

$ ls man/man1\ \ blib/man5\ /tmp/BUILD-PlOaXk/main/share/man/man5/ razor-admin.1 razor-check.1 razor-report.1 razor-revoke.1

I think the problem is in Makefile.PL, lines 150-153:

150 my $man5 = q{ \ 151 >···>···$(INST_MAN5DIR) $(INSTALLMAN5DIR)}; 152 153 $inherited =~ s/(\$((?:DEST)?INSTALL\w*MAN1DIR))/$1$man5/gm;

That regexp substitution looks to me like it is getting mangled. What do you think?

Sorry I cannot provide a patch right now, have other stuff on my plate. Let me know if you need help in fixing this.

Cheers, Gonzo

bes-internal commented 5 years ago

diff -uprw razor-agents-2.85.orig/Makefile.PL razor-agents-2.85/Makefile.PL
--- razor-agents-2.85.orig/Makefile.PL 2007-05-09 01:47:53.000000000 +0300
+++ razor-agents-2.85/Makefile.PL      2015-06-14 20:36:23.677213987 +0300
@@ -140,9 +140,9 @@ sub MY::install {
   my $inherited = $self->SUPER::install(@_);

   my $man5 = q{ \\
-              $(INST_MAN5DIR) $(INSTALLMAN5DIR)};
+              "$(INST_MAN5DIR)" "$(INSTALLMAN5DIR)"};

-  $inherited =~ s/(\$\((?:DEST)?INSTALL\w*MAN1DIR\))/$1$man5/gm;
+  $inherited =~ s/("?\$\((?:DEST)?INSTALL\w*MAN1DIR\)"?)/$1$man5/gm;

   return $inherited;
 }

toddr commented 5 years ago

@bes-internal this doesn't seem to match master in any way. I think this was addressed in cb7e4a4ef1a4ad1cfdaa39916c2d5cbbbe13cd2a

toddr commented 5 years ago

Closing. please re-open if the issue is still present.

toddr / Razor2-Client-Agent

Possible bug in Razor2-Client-Agent-2.84 #3