toddsundsted / ktistec

Single user ActivityPub (https://www.w3.org/TR/activitypub/) server.
GNU Affero General Public License v3.0
350 stars 21 forks source link

Fails to build with Crystal 1.7.0 #65

Closed mohd-akram closed 1 year ago

mohd-akram commented 1 year ago

I get this error when building:

Error target ktistec failed to compile:
In src/rules/content_rules.cr:23:33

 23 | class ::ActivityPub::Activity include School::DomainType end
                                    ^
Error: unexpected token: "include"
toddsundsted commented 1 year ago

@mohd-akram what version of crystal are you using? and os.

toddsundsted commented 1 year ago

interesting, it fails for me with 1.7.1 (i see the title now)

toddsundsted commented 1 year ago

it's easy enough to fix. but let me check first and see if this change was intentional or a regression.

toddsundsted commented 1 year ago

thanks for reporting. created https://github.com/crystal-lang/crystal/issues/12974

mohd-akram commented 1 year ago

Thanks for following up on this. Crystal 1.7.2 has been released with a fix and ktistec successfully builds now.