search

toddsundsted / ktistec

Single user ActivityPub (https://www.w3.org/TR/activitypub/) server.
GNU Affero General Public License v3.0
360 stars 20 forks source link

tag duplicate in a same post & `#` in code block is not tag #97

Closed qaqland closed 4 months ago

qaqland commented 5 months ago

my code block has some c macro

image

https://qaq.land/tags/pragma

Ktistec Version 2.0.0-10

toddsundsted commented 5 months ago

good catch! thanks!

toddsundsted commented 5 months ago

fixed in a6ea1385. can you confirm?

qaqland commented 5 months ago

new post fixed, what about old post🤔

toddsundsted commented 5 months ago

you should be able to edit the old post and publish again (as an update). editing always starts with the original source, and when that source is resaved, it will be reprocessed, but this time it won't create hashtags (and the old hashtags will be destroyed).

qaqland commented 5 months ago

could you access my instance https://qaq.land ?

it still has https://qaq.land/tags/define and https://qaq.land/tags/pragma

2024-04-30 17:24:26 UTC 200 GET /tags/define 3.72ms
2024-04-30 17:24:29 UTC 200 GET /tags/pragma 5.56ms
2024-04-30 17:26:02 UTC 409 POST /actors/qaq/inbox 510.07ms
2024-04-30 17:27:53 UTC 404 GET /tags/pragma2 3.72ms
toddsundsted commented 5 months ago

interesting. that should have deleted the tags in addition to just the tag markup. i'll take a look at it

toddsundsted commented 5 months ago

yep, found a bug. when all tags are removed from the post none of the tags get removed.

toddsundsted commented 5 months ago

ok, this bug is fixed in a824ce02. if you edit those posts and then update, it should correctly remove the hashtag database entries, as well.

toddsundsted commented 5 months ago

@qaqland these two fixes should address the issue you mentioned. can you confirm?

qaqland commented 4 months ago

yes, works well. Thank you!