toddw123 / RotMG_Clientless

Compatible with version X16.0.0
MIT License
11 stars 4 forks source link

Add more client packets #17

Closed Zeroeh closed 7 years ago

toddw123 commented 7 years ago

Hmmm....i was about to merge this but then started to notice a few things that confused me. Are you using an old version of k-relay or something to create these packets? I would like these packets to reflect the client as much as possible, and a few of them you dont even have the structure correct:

I will fix all of these, but please if you add more packets in the future make sure they are modeled after the client as far as the packet names goes and variable names, and that they are not outdated.

Other then those few errors, the rest is wonderful! Thank you!

Zeroeh commented 7 years ago

Yeah I was looking at krelay for the their structure. I'll decompile the client and use that source then.

toddw123 commented 7 years ago

yeah k-relay, especially the source on github, is not a good reference. A lot of the packets from that source have been renamed, and some of them have different structures now. I prefer to use the client source since its going to be the most up to date obviously haha. Basically you go to the packet section of the client and they have an incoming and outgoing folder with the packet classes. That is what im trying to model the classes in this project after.