search

toddwschneider / ballr

Interactive NBA and NCAA Shot Charts with R and Shiny
MIT License
598 stars 130 forks source link

Career-long Charts #1

Open airstrike opened 8 years ago

airstrike commented 8 years ago

Hi,

First of all, congratulation on this fantastic work. I honestly believe the pros at NBA are going to check these charts out quite a bit. You can get a lot of information out of them, and very intuitively so.

Have you considered allowing users to not filter by season, therefore getting stats for a player's entire career? I'm sure many would like to see that. I think you can take that a step further and do charts that compare a player's performance against his own, across his career, highlighting good and bad years. It should allow us to see when a player peaked and compare his performance across different teams.

Anyway, keep up the good work!

toddwschneider commented 8 years ago

Thanks. I agree career-long charts would be a good addition. In the meantime you can do stuff like this to grab all shots for a player: https://github.com/toddwschneider/ballr/blob/master/lebron.R#L4-L7

I might look into adding multi-season charts as an option in the main app, though I worry that the multiple NBA API requests will take too long for a single web request. One possibility is to build a custom backend that caches NBA data and exposes an endpoint to get career-long charts in a single request, but that'll be a bunch more work too...

toddwschneider commented 6 years ago

@airstrike no real update here, but I made a new project to store all shots in a database, check it out here: https://github.com/toddwschneider/nba-shots-db

Still some work to do to connect this app to that database to provide career-long charts, but it's a step in the right direction