search

todogroup / repolinter

Repolinter, The Open Source Repository Linter
https://todogroup.github.io/repolinter/
Apache License 2.0
421 stars 72 forks source link

Update versions of node in Dockerfile. Fixes ci. #281

Closed JeroenKnoops closed 1 year ago

JeroenKnoops commented 1 year ago

Motivation

Currently the docker build is failing because of the usage of node:buster instead of node:bullseye. When installing ruby this defaults to an incompatible version.

Proposed Changes

Switch to node:bullseye. When installing ruby it defaults to ruby 2.7, which is fine for us.

Test Plan

Build the docker image locally.

$docker build -t repolinter .

Tested the docker image locally.

$docker run repolinter
JeroenKnoops commented 1 year ago

PR #280 will fix the "ci / Node x" jobs.

hyandell commented 1 year ago

Thanks again - much needed fixes here; very happy you were able to help out :)