Closed GoogleCodeExporter closed 9 years ago
I'll have a look at this shortly, but it sounds like a good idea.
Original comment by duckt...@gmail.com
on 30 Jun 2009 at 3:53
I've added your code to the project. Unfortunately, it doesn't entirely work. I
created a new branch "sms" for development of this feature. I've added you as a
member to this project, so you should now have commit access (using Mercurial).
Please commit any changes to the "sms" branch rather than the default one.
I think the following are needed before merging into the main branch:
1. It should actually work.
2. There should be a preference (defaulting to "off") for whether SMS messages
are
automatically received by the program. Otherwise, this may cause a security
problem
(since users don't have control over what SMS messages they receive).
3. Ideally, it should display the vCard to the user and ask whether to add it to
contacts (rather than automatically doing so).
Original comment by duckt...@gmail.com
on 1 Jul 2009 at 4:49
strange that it does not work, I'll have a look at it
Original comment by franci...@gmail.com
on 1 Jul 2009 at 9:43
the contact is added but there is no proper way of getting rid of the
notification
Original comment by franci...@gmail.com
on 1 Jul 2009 at 9:55
did some initial work on an activity to accept the vcard, more later this week
Original comment by franci...@gmail.com
on 1 Jul 2009 at 11:24
ducktayp, can you have a look at it now and see if 1 and 3 are fixed
I need to read up on how to save user preferences so I can skip notification
when that
functionality is disabled
Original comment by franci...@gmail.com
on 2 Jul 2009 at 9:15
Just added a checkbox to the main app activity to enable or disable sms vcard
receiving. So that's it for 2. Maybe we should put that option in a real
android
settings menu.
All we might need is a fancier vcard view. But for that the VCardIO class needs
to be
changed.
Original comment by franci...@gmail.com
on 2 Jul 2009 at 9:41
francisdb, I can't see any changes in the repository. Did you do an "hg push"
after
committing?
Original comment by duckt...@gmail.com
on 3 Jul 2009 at 3:51
first time I use mercurial, push performed
Original comment by franci...@gmail.com
on 3 Jul 2009 at 5:48
now showing the contact after import of the vcard
ducktayp, can you have a look at it?
Original comment by franci...@gmail.com
on 10 Jul 2009 at 10:46
Ducktayp, did you check out my changes? I'd like to see them released :-)
Original comment by franci...@gmail.com
on 24 Jul 2009 at 2:38
It looks good to me. I didn't have time to do much testing, though.
I put up a version in the downloads section and a pointer from the project
homepage.
If there are no significant bugs filed in the next few weeks, I'll make it the
featured version and upload to the market.
Original comment by duckt...@gmail.com
on 27 Jul 2009 at 5:41
that's great news :-)
Original comment by franci...@gmail.com
on 1 Aug 2009 at 9:58
Original comment by duckt...@gmail.com
on 12 Oct 2009 at 6:50
Original issue reported on code.google.com by
franci...@gmail.com
on 28 Jun 2009 at 8:48Attachments: