search

todotxt / todo.txt-cli

☑️ A simple and extensible shell script for managing your todo.txt file.
http://todotxt.org
GNU General Public License v3.0
5.56k stars 713 forks source link

Priority B default color is not bold #339

Open YodaEmbedding opened 3 years ago

YodaEmbedding commented 3 years ago

The default todo.cfg contains:

export GREEN='\\033[0;32m'
export PRI_B=$GREEN

However, for consistency with the other priorities (which are bold), it should actually be:

export GREEN_BOLD='\\033[1;32m'
export PRI_B=$GREEN_BOLD
inkarkat commented 3 years ago

All "light" default colors (but oddly DARK_GREY, not LIGHT_GREY) are bold. I would come to the conclusion that these colors were not clearly distinguishable to the original author (based on their color scheme and terminal background), so they were made bold. Therefore, I would not deduce that green should be bold as well.

The colors and priority highlightings are easily customized in the config file; the one that's shipped is just a template and documents the built-in defaults. I personally would argue that changing the default would affect more (existing) users negatively (in that they have to recognize the change and adapt) than what the consistency would bring for new users.

xsrvmy commented 2 years ago

If the desire is to change the color, rather than to use bold, it may be better to use escape codes 90-97 (which selects bright colors without causing them to be bold) instead of 30-31 bold actually. Some terminals don't even use bright for bold by default anymore.

BTW DARK_GREY is bold because it's actually bright black, and LIGHT_GREY is dark white.