todotxt / todo.txt-cli

☑️ A simple and extensible shell script for managing your todo.txt file.
http://todotxt.org
GNU General Public License v3.0
5.56k stars 713 forks source link

Fix issue #361 - add persistence for priority on completion, as an option defaulting to original behavior #362

Open wwalker opened 2 years ago

wwalker commented 2 years ago

Before submitting a pull request, please make sure the following is done:

Reviewer, manual QA of change: Setup:

todo.sh add "(A) my task loses priority"
todo.sh add "(A) my task keeps priority"

Testing: Verify no change in existing functionality: Run:

@$ todo.sh do 1
1 x 2021-09-19 my task loses priority
TODO: 1 marked as done.

Verify that the Priority is removed, as is the currently expected behavior:

@$ todo.sh list
2 (A) my task keeps priority
1 x 2021-09-19 my task loses priority
--
TODO: 2 of 2 tasks shown

Verify that the new feature works (allow persistence of priority after completion, if user specifies -m): Run:

@$ todo.sh -m do 2
2 x 2021-09-19 (A) my task keeps priority
TODO: 2 marked as done.

Verify that the Priority persists after the completion:

@$ todo.sh list
2 x 2021-09-19 (A) my task keeps priority
1 x 2021-09-19 my task loses priority
--
TODO: 2 of 2 tasks shown
chrysle commented 1 year ago

@wwalker Is this still work in progress?