Different folder to copy ~/.todo.cfg for macOS on arm/x86 CPU

todotxt / todo.txt-cli

☑️ A simple and extensible shell script for managing your todo.txt file.

http://todotxt.org

GNU General Public License v3.0

5.56k stars 713 forks source link

Different folder to copy ~/.todo.cfg for macOS on arm/x86 CPU #369

Closed xqliu closed 2 years ago

xqliu commented 2 years ago

Before submitting a pull request, please make sure the following is done:

[x] Fork the repository and create your branch from master.
[x] If you've added code that should be tested, add tests!
[x] Ensure the test suite passes.
[x] Format your code with ShellCheck.
[x] Include a human-readable description of what the pull request is trying to accomplish.
[x] Steps for the reviewer(s) on how they can manually QA the changes.
[x] Have a fixes #XX reference to the issue that this pull request fixes.

xqliu commented 2 years ago

Dear, please see the follow for homebrew install directory on Mac with m1 chip

https://mac.install.guide/homebrew/index.html

Here is a screenshot:

For the wording, I think your suggestion is quite good. let me change them according.

Thanks for your review

karbassi commented 2 years ago

@xqliu could you work on the tests? They are failing for macOS.

https://github.com/todotxt/todo.txt-cli/runs/4216039911?check_suite_focus=true

inkarkat commented 2 years ago

@xqliu could you work on the tests? They are failing for macOS.

This PR only updates the readme, no code; I think this is a general problem, and this PR simply is the first run where it surfaced.

The failing test is add to file without EOL; I suspect that the macOS version (or some dependencies) got updated, and now there's a different behavior of linefeed handling (somehow), and that's breaking the test.

Does GitHub automatically update the CI system images? It would be fantastic if such an update would also automatically trigger the CI, so that any compatibility issue could be detected right away and not just when the next PR is submitted. Alternatively, if there's a feed / event / notification one could subscribe to, one of us could then manually trigger a CI build.

karbassi commented 2 years ago

This is my fault. 🙃

I should have looked at the changes and not just the CI checks.

Approved 👍🏽 and merging 🎉.