Open chrysle opened 1 year ago
Unfortunately, you're written the test to match the implementation, not to actually verify the specified behavior; and that actually was broken (good that we insisted on having tests). I've corrected both in my commit. It still doesn't handle default parameters that have spaces or other special characters; I'll add that later.
Thanks for your help! What special parameters for example do you mean that should be tested?
@inkarkat I would like to relieve you of implementing the tests if ou give me some hints.
Thanks for the review @chrysle; the original implementation was woefully incomplete and wrong, but only writing the tests showed what looked quite alright to a casual review. From my point of view this is now done, and we just have to wait for the merge of the huge backlog of open issues...
Did you notice the test for macOS 10.15 succeeded? I wonder why it was always cancelled before.
Before submitting a pull request, please make sure the following is done:
master
.fixes #XX
reference to the issue that this pull request fixes.This finishes leftover work from #159 That PR can be closed then.
I added a test, a docstring and also a note for
TODOTXT_DEFAULT_ACTION
to the config file.