search

todotxt / todo.txt-ios

Official Todo.txt iOS app for managing your todo.txt file stored in Dropbox.
http://todotxt.org
GNU General Public License v3.0
380 stars 109 forks source link

Split view for filtering on iPad (issue #81) #164

Closed brendonjustin closed 11 years ago

brendonjustin commented 11 years ago

Straightforward implementation of the issue #81 mockup.

Some notes:

Edited for specificity.

ginatrapani commented 11 years ago

GASP So exciting! Thank you! Can't wait to try it.

ginatrapani commented 11 years ago

This is a great start! So far testing is going well, especially with that last commit. One bug: the app crashes whenever you tap the settings button.

brendonjustin commented 11 years ago

That was a silly mistake. Fixed.

ginatrapani commented 11 years ago

So nice! Looking great. One other minor bug: Lengthy task text runs off to the side of the list view, and in the Task Details view. Looks like we just have to adjust the wrap margin for them when the iPad is in landscape.

ginatrapani commented 11 years ago

Another minor bug: If you've got a context or project that only has one task associated with it, then you filter by that project or context and delete the task, you get the "Your todo.txt file is empty" message, which isn't really true -- it's just that there are no tasks which match the filter.

Is the list view aware that it's being filtered? If so, let's display a "No tasks match [context/project]."

brendonjustin commented 11 years ago

Another way to get that situation is to filter such that no one task has all of the selected contexts, so there are no results. I'll see how I'd go about showing a different message.

(It is aware when it is being filtered.)

Regarding text layout, I'd like to bump the minimum target to iOS 6.0 and use Auto Layout. It might eliminate the FlexiTaskCell subclasses, and I've got my eye on adapting for iOS 7 in the future.

ginatrapani commented 11 years ago

I'm fine with an iOS 6.0 minimum target, and using Auto Layout. Also happy about adapting for iOS 7. Hooray!

ginatrapani commented 11 years ago

I see the informative message, which is great, but it's all I see--I'm not seeing the list of tasks even when nothing is selected.

brendonjustin commented 11 years ago

I'm making some changes to the TaskBag protocol so I can make the split view work well. I might be a few days.

ginatrapani commented 11 years ago

Cool, thanks for the update.

brendonjustin commented 11 years ago

I misjudged the changes I'd need to make. Other than longer tasks not being sized quite correctly, the split view should work now.

brendonjustin commented 11 years ago

Abandoning this in favor of PR #165