search

todotxt / todo.txt-ios

Official Todo.txt iOS app for managing your todo.txt file stored in Dropbox.
http://todotxt.org
GNU General Public License v3.0
379 stars 112 forks source link

Restore network logic that didn't use ReactiveCocoa #217

Closed brendonjustin closed 10 years ago

brendonjustin commented 10 years ago

I think I made a mistake using ReactiveCocoa before, so I'm seeing about removing it and mostly restoring the previous syncing logic.

If you agree, I can remove it as a dependency entirely without much trouble in another PR.

ginatrapani commented 10 years ago

Hey Brendon, sorry I've been away from this for so long. If you're still up for this, I'd love to know more - what made you decide to use ReactiveCocoa in the first place and why you think you made a mistake. That would help me decide if it's worth it - seems like it would, at least, simplify the codebase by removing the dependency.

brendonjustin commented 10 years ago

I can write (some) logic faster using ReactiveCocoa than without, so I am usually inclined to use it. I don't think it was a good idea in this case because of RAC's steep learning curve. If I didn't know it or plan on learning it, I wouldn't want it in a project that I maintain. A strange looking library probably deters potential contributors, too.

ginatrapani commented 10 years ago

Yep, makes sense. I'd definitely merge a PR that removed it. Thanks for helping us keep things simple.

brendonjustin commented 10 years ago

I don't know if I'll have time to do this soon, so don't wait around for it.

ginatrapani commented 10 years ago

Understood. Thanks Brendon.

Sent from my mobile On Jun 18, 2014 8:57 PM, "Brendon Justin" notifications@github.com wrote:

I don't know if I'll have time to do this soon, so don't wait around for it.

— Reply to this email directly or view it on GitHub https://github.com/ginatrapani/todo.txt-ios/pull/217#issuecomment-46512860 .

brendonjustin commented 10 years ago

Superseded by #225