search

todotxt / todo.txt-ios

Official Todo.txt iOS app for managing your todo.txt file stored in Dropbox.
http://todotxt.org
GNU General Public License v3.0
379 stars 112 forks source link

Priority/Context action sheets no longer display items within iOS 8 #230

Closed stevendpclark closed 9 years ago

stevendpclark commented 9 years ago

After upgrading to iOS 8, the Priority/Context action sheet pickers fail to work within the edit task screen, nor does the sort action sheet picker work on the main screen.

ios simulator screen shot sep 24 2014 11 24 35 pm

I believe this problem is due to the iOS todo.txt project using an older version of the ActionSheetPicker project. It will need to be updated to use the new forked version.

kud1ing commented 9 years ago

I have this too.

sukima commented 9 years ago

Same here. Any one got any ideas on what might be the cause? Or perhaps seen something similar in other apps?

ginatrapani commented 9 years ago

Anyone available to try to upgrade ActionSheetPicker? My first try failed with many build errors.

chuckbjones commented 9 years ago

I've got it almost figured out. A lot of the API changed.

chuckbjones commented 9 years ago

Sent a PR. Only tested on simulators (iPhone 5s and iPad Air). Couldn't figure out how to run unit tests. It looks like the framework we were using is no longer supported?

ginatrapani commented 9 years ago

Thanks again Chuck! re: testing framework, I upgraded us from OCUnit to XCTest in https://github.com/ginatrapani/todo.txt-ios/commit/13f8cb283077cc2b8e3d5ccd56efd4f392e4acf4

We have some "issues" in the StringsTest but I think they're just a syntax issue.

stevendpclark commented 9 years ago

Thanks Chuck for fixing the issue, just didn't have time to get around to it.

I have created a pull request to fix the issues running the unit tests within https://github.com/ginatrapani/todo.txt-ios/pull/232

sukima commented 9 years ago

I've tested the merge on iOS 8.0 (iPhone 5s) and it works. :heavy_check_mark: