Convert to jekyll - Githubissues

karbassi commented 6 years ago

Fixes #14

donovanglover commented 6 years ago

Sorry I'm just now getting to this. Here's my review.

The Gemfile and Gemfile.lock files aren't needed. Jekyll will work just fine without them, and IMO only complicates the build process. I don't think GitHub Pages takes them into account, either.
Quotes are missing for the links inside apps-mobile.yml.
Are any of the plugins in _config.yml being used?
I don't have any of the files excluded in _config.yml. I believe the entire section can be safely removed.
The 404 page could be better. How about linking to or redirecting to the homepage?

Everything else looks fine to me. I got no errors. Some differences from the current site (not sure if you're aware):

The current site has the Android link removed. This version still has it.
Some of the items under "Community Apps" have a by tagline and other information in the live version. This version doesn't.

With the most important parts converted to Jekyll, making a new design with the site content should be a lot easier now.

These are all of the things that I noticed. Glad that you took the time to do this!

donovanglover commented 6 years ago

Can you check my review? Would like to see this merged into master.

clach04 commented 2 years ago

@donovanglover and @karbassi what's needed to move this forward? I posted https://github.com/karbassi/todotxt.github.io/pull/1 which is based on this PR (and similar change for existing html version https://github.com/todotxt/todotxt.github.io/pull/50

todotxt / todotxt.github.io