search

todvora / gitbook-plugin-image-captions

Image captions plugin for GitBook
Apache License 2.0
44 stars 18 forks source link

Caption for video link #4

Closed michaellwest closed 8 years ago

michaellwest commented 8 years ago

Thank you for publishing this great plugin. I have a scenario which I think previously worked.

Can you support something like this? Basically I need a thumbnail with a video link that opens in a new tab.

[![SPE Remoting Module](http://img.youtube.com/vi/fGvT8eDdWrg/0.jpg)](http://www.youtube.com/watch?v=fGvT8eDdWrg "Click for a quick demo")

image

todvora commented 8 years ago

Hi Michael, Thank you for reporting this issue. You are right, it has been working earlier. It should be fixed now in the release 0.3.1. You can try it using the latest release or force gitbook to use exactly 0.3.1 by defining this in your book.json:

{
    "plugins": ["image-captions@0.3.1" ]
}

Real working example of your code can be seen on https://tdvorak.gitbooks.io/test-book/content/phetchaburi.html

I used your example also in tests to prevent any similar bug in future. Is it ok for you?

Thanks, Tomas

michaellwest commented 8 years ago

Hey that's great! Thank you for the quick turnaround. I'll test later by rebuilding my book.Feel free to use the example for your tests.

michaellwest commented 8 years ago

Back in action. Thanks!

todvora commented 8 years ago

:+1: Glad I could help