search

toeb / accounting

3 stars 0 forks source link

Cleanup Account Model #28

Open matthiaszoellner opened 9 years ago

matthiaszoellner commented 9 years ago

Current Account Model is a bit bloated with Id-like properties.

We have Meta.Id, Account.Number and Account.ShortName. As I see, both, Number and ShortName have the same intention, so we should remove one soon, to avoid confusion.

toeb commented 9 years ago

The Id is an internal unique identifier. It has to stay Number is the logical accountnumber ie D000199 ShortName is the accounts Short name - e.g. Tobias Becker Name is the accounts full name e.g. Customer Account Tobias Becker

ShortName & Name migth be redundant but it is good practice to have both

So I do not see that we should change it (since there are no costs to it and there might even be more fields we will add in the future?

matthiaszoellner commented 9 years ago

Ok, then we should update the OpenAccount Command, since it doesn't handle ShortName. This made me think, that there is no value to this field.

At least, we should add documentation comments to clarify the usage of each field.