search

toeb / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

gtest-port_test.cc uses testing::Types unconditionally #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Use of testing::Types should always be guarded by

#if GTEST_HAS_TYPED_TEST || GTEST_HAS_TYPED_TEST_P

Reported by Tor Didriksen.

Original issue reported on code.google.com by vladlosev on 3 Nov 2009 at 6:22

GoogleCodeExporter commented 9 years ago 
Issue 238 has been merged into this issue.

Original comment by w...@google.com on 22 Dec 2009 at 5:36

GoogleCodeExporter commented 9 years ago 
There might be a problem with test/gtest-port_test.cc: if GTEST_USES_POSIX_RE 
is set 
and GTEST_HAS_TYPED_TEST unset, no regex tests are compiled:

#if GTEST_USES_POSIX_RE && (GTEST_HAS_TYPED_TEST || GTEST_HAS_TYPED_TEST_P)
...not compiled, because GTEST_HAS_TYPED_TEST is unset
#elif GTEST_USES_SIMPLE_RE
...not compiled, because GTEST_USES_SIMPLE_RE is unset
#endif  // GTEST_USES_POSIX_RE

Original comment by maciej.b...@gmail.com on 22 Dec 2009 at 7:20

GoogleCodeExporter commented 9 years ago

Original comment by vladlosev on 26 Feb 2010 at 10:27