search

toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
35.49k stars 2.35k forks source link

​Improving the block selection button #7017

Open EnterMan123 opened 1 month ago

EnterMan123 commented 1 month ago

Description

This is a suggestion feedback: Improve the button appearance style for selecting blocks

It's too small and has unnecessary animation effects. I'm often distracted from my limited attention by the shrinking animation effect. Additionally, it can be mistaken for something other than a button, perhaps its appearance could be improved to emphasize that it actually has more functionality.

2

gif 👇 3 5

Use case

No response

Anything else?

No response

Are you willing to submit a PR?

affine-issue-bot[bot] commented 1 month ago

Issue Status: 💬 To be Discussed

💬 To be Discussed

We need some time to discuss the issue.

This is an automatic reply by the bot.

houshasen commented 1 month ago

I actually like the animation. ☺️

The expanded line indicates which group of lines/blocks will be selected upon grabbing it rather than just a single line.

https://github.com/toeverything/AFFiNE/assets/48835895/ebffa15f-ab93-4777-8cef-5c9009139821

I think the feature is useful whenever blocks have a group. Currently, this may be just limited when there is tab indentation case; however, if developers introduce additional ways to group blocks, such as a note block option or split columns, this functionality could see improved utility.

One potential usability enhancement could involve differentiating actions between right-click and left-click when grabbing the bar. This distinction would allow users to choose between selecting a single block or a group of blocks. This feature might be particularly useful when trying to select a line that has indented blocks beneath it. Currently, there doesn't seem to be a straightforward way to grab just the line without also selecting the child blocks.

Another visual enhancement to consider is inconsistent ghost effect on grabbed text. I think all should show the whole blocks grabbed.

https://github.com/toeverything/AFFiNE/assets/48835895/b14347f2-5bd9-41ad-8b55-aec478d4230f

EYHN commented 1 month ago

@hwangdev97 Can you take a look at optimizing this animation?