toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
35.3k stars 2.32k forks source link

refactor(core): view transition api for peek-view modal animation #7350

Closed pengx17 closed 4 days ago

pengx17 commented 4 days ago

Remaining issue: modal controls' position is not relatively moved to the parent container during transitioning.

graphite-app[bot] commented 4 days ago

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 commented 4 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

nx-cloud[bot] commented 4 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 81462fe000593aeeeec83a326dde85ad3ae0b2a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx test:coverage @affine/monorepo`](https://cloud.nx.app/runs/FJZrDkEcwF?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/SeWwTdzMk9?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-cross`](https://cloud.nx.app/runs/2hxm9qeDdy?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/Dhxuddxzk4?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/LEDTw68HvY?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target aarch64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/CFF8zStwM2?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 27.58621% with 21 lines in your changes missing coverage. Please review.

Project coverage is 58.28%. Comparing base (03af538) to head (b389697).

:exclamation: Current head b389697 differs from pull request most recent head 81462fe

Please upload reports for the commit 81462fe to get more accurate results.

Files Patch % Lines
...dules/peek-view/view/doc-preview/doc-peek-view.tsx 7.69% 12 Missing :warning:
...ore/src/modules/peek-view/view/modal-container.tsx 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## canary #7350 +/- ## ========================================== + Coverage 58.26% 58.28% +0.02% ========================================== Files 854 854 Lines 37709 37703 -6 Branches 4086 4083 -3 ========================================== + Hits 21970 21976 +6 + Misses 15445 15431 -14 - Partials 294 296 +2 ``` | [Flag](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | Coverage Δ | | |---|---|---| | [server-test](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `77.91% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `28.37% <27.58%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

graphite-app[bot] commented 4 days ago

Merge activity