toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
35.29k stars 2.32k forks source link

fix: escape key handling compatibility issue with blocksuite #7365

Closed pengx17 closed 3 days ago

pengx17 commented 3 days ago

fix PD-1347

See https://github.com/radix-ui/primitives/blob/main/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx#L19-L20

This behavior in radix-ui is not possible to be prevented since escape keydown is bound to document with capturing, unless dialogs in blocksuite is also implemented with radix-ui.

pengx17 commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

nx-cloud[bot] commented 3 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 34b6a3bf1f3a52883da3417100a9af040155d66c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx test:coverage @affine/monorepo`](https://cloud.nx.app/runs/f0hJXovpxM?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/CKXmdiupTM?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-cross`](https://cloud.nx.app/runs/7MBoNRoW8r?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/vZI2viIHox?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/2985vby6tt?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target aarch64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/2CJrWRZLvJ?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

graphite-app[bot] commented 3 days ago

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 28.32%. Comparing base (eca484d) to head (34b6a3b).

Files Patch % Lines
...ore/src/modules/peek-view/view/modal-container.tsx 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## canary #7365 +/- ## ========================================== - Coverage 28.34% 28.32% -0.02% ========================================== Files 654 654 Lines 14938 14946 +8 Branches 2626 2627 +1 ========================================== Hits 4234 4234 - Misses 10460 10468 +8 Partials 244 244 ``` | [Flag](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `28.32% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

graphite-app[bot] commented 3 days ago

Merge activity