Closed pengx17 closed 3 days ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @pengx17 and the rest of your teammates on Graphite
CI is running/has finished running commands for commit 34b6a3bf1f3a52883da3417100a9af040155d66c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
Attention: Patch coverage is 0%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 28.32%. Comparing base (
eca484d
) to head (34b6a3b
).
Files | Patch % | Lines |
---|---|---|
...ore/src/modules/peek-view/view/modal-container.tsx | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pengx17
added this pull request to the Graphite merge queue.pengx17
merged this pull request with the Graphite merge queue.
fix PD-1347
See https://github.com/radix-ui/primitives/blob/main/packages/react/use-escape-keydown/src/useEscapeKeydown.tsx#L19-L20
This behavior in radix-ui is not possible to be prevented since escape keydown is bound to document with capturing, unless dialogs in blocksuite is also implemented with radix-ui.