toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
40.89k stars 2.65k forks source link

feat(core): allow keyboard navigation in tags inline editor #7378

Closed pengx17 closed 2 months ago

pengx17 commented 3 months ago

fix AF-966

pengx17 commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2a6ea3c9c6b408e48e4a8430d7c1f9ef670035eb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx test:coverage @affine/monorepo`](https://cloud.nx.app/runs/y7lhRXVhH9?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/zvjYOSknHI?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-cross`](https://cloud.nx.app/runs/qpQrqZZmJI?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/C6kLr5OiIZ?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target aarch64-apple-darwin --use-napi-cross`](https://cloud.nx.app/runs/cNVQo4FNIe?utm_source=pull-request&utm_medium=comment) - [`nx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross`](https://cloud.nx.app/runs/x8B5VG3NV0?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

graphite-app[bot] commented 3 months ago

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 2.04082% with 48 lines in your changes missing coverage. Please review.

Project coverage is 28.91%. Comparing base (c62d79a) to head (2a6ea3c).

Files Patch % Lines
...ents/affine/page-properties/tags-inline-editor.tsx 2.04% 48 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## canary #7378 +/- ## =========================================== - Coverage 57.23% 28.91% -28.33% =========================================== Files 902 702 -200 Lines 39401 16656 -22745 Branches 4417 2971 -1446 =========================================== - Hits 22552 4816 -17736 + Misses 16497 11538 -4959 + Partials 352 302 -50 ``` | [Flag](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7378/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | Coverage Δ | | |---|---|---| | [server-test](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `?` | | | [unittest](https://app.codecov.io/gh/toeverything/AFFiNE/pull/7378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `28.91% <2.04%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

graphite-app[bot] commented 2 months ago

Merge activity

abhi9dev commented 1 week ago

hey @pengx17 I noticed that for the first time when you add the tag using enter keyword it happens successfully, but for the second time when I try to add the tag using enter keyword it fails, I have to manually click on the create tag-name option from dropdown.