toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
42.67k stars 2.79k forks source link

fix(electron): electron sentry is not correctly enabled #8856

Closed pengx17 closed 6 days ago

pengx17 commented 6 days ago

image.png

graphite-app[bot] commented 6 days ago

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 commented 6 days ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

nx-cloud[bot] commented 6 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bc23a237d2d74a0207f6e7aeff0fba0b3c620c57. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx test:coverage @affine/monorepo`](https://cloud.nx.app/runs/OiRRKF9cVB?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.25%. Comparing base (9261bb2) to head (bc23a23). Report is 1 commits behind head on 11-18-fix_electron_potential_crash_on_quit.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 11-18-fix_electron_potential_crash_on_quit #8856 +/- ## ============================================================================== - Coverage 70.30% 70.25% -0.06% ============================================================================== Files 550 550 Lines 33980 33980 Branches 3052 3052 ============================================================================== - Hits 23889 23871 -18 - Misses 9719 9737 +18 Partials 372 372 ``` | [Flag](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8856/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | Coverage Δ | | |---|---|---| | [server-test](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `77.14% <ø> (-0.07%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `46.08% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: