search

toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.
https://affine.pro
Other
42.77k stars 2.8k forks source link

feat(core): at menu journal entries #8877

Closed pengx17 closed 1 day ago

pengx17 commented 1 week ago

performance improvement:

fix AF-1790 When at menu appears or user query changes, the getMenu function will recomputed the title & icon of every doc in the workspace. In the original implementation, this will create a lot of adhoc LiveData instances but their values are never watched. The overhead is significant if there are many docs in the workspace.

This PR remove LiveData uses in this specific case. Also breaks down the long sync task for smoother user interaction.

depends on https://github.com/toeverything/blocksuite/pull/8780

journal enhancement

fix AF-1774 added DateSelectorDialog for selecting a date through blocksuite; added AtMenuConfigService for constructing the at menu config

e2e tests

fix AF-1776 fix PD-1942

graphite-app[bot] commented 1 week ago

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7161d022d99f6bb6cc40f54b3109de1f7313fb07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx test:coverage @affine/monorepo`](https://cloud.nx.app/runs/mxrMJsgGpV?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 27.43902% with 119 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (e3a8f1e) to head (7161d02).

Files with missing lines Patch % Lines
.../core/src/modules/at-menu-config/services/index.ts 29.93% 102 Missing and 1 partial :warning:
...ntend/core/src/modules/journal/services/journal.ts 5.88% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## canary #8877 +/- ## ========================================== - Coverage 70.54% 64.89% -5.65% ========================================== Files 544 659 +115 Lines 33772 37311 +3539 Branches 3008 3596 +588 ========================================== + Hits 23823 24213 +390 - Misses 9585 12730 +3145 - Partials 364 368 +4 ``` | [Flag](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8877/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | Coverage Δ | | |---|---|---| | [server-test](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `77.13% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/toeverything/AFFiNE/pull/8877/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything) | `35.01% <27.43%> (-11.55%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toeverything#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

perfsee[bot] commented 5 days ago

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …arge_doc_list                 +/- ##
===================================================================
< Bundle              22.9 MB        23.5 MB     +637 kB(+2.79%)   
< Initial JS          9.64 MB        9.98 MB     +344 kB(+3.57%)   
< Initial CSS          199 kB         248 kB   +48.3 kB(+24.22%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   76             82                  +6   
< Chunks                   74             80                  +6   
= Packages                294            294                       
= Duplicates                7              7                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting
graphite-app[bot] commented 1 day ago

Merge activity