toeverything / blocksuite

🧩 Content editing tech stack for the web - BlockSuite is a toolkit for building editors and collaborative applications.
https://blocksuite.io
Mozilla Public License 2.0
4.09k stars 353 forks source link

fix(blocks): code block and image block pop-over z-index issues in affine #7409

Closed golok727 closed 1 week ago

golok727 commented 1 week ago

Create a new stacking context at the editor-host, allowing popups to use it as the parent context instead of body.

BS-667 BS-635

Before

https://github.com/toeverything/blocksuite/assets/123532141/6bfdff21-4d3f-4fb1-afd2-09b9ceb32130

After

https://github.com/toeverything/blocksuite/assets/123532141/1182f012-dbcd-40c1-8f92-f9063744e5fc

graphite-app[bot] commented 1 week ago

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 8:47am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **blocksuite-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/toeverything/blocksuite-docs/4nQrp1kPyGCmGdD7CfqFR5NMTrKv)) | [Visit Preview](https://blocksuite-docs-git-06-25-fixblockscodebloc-e7a86f-toeverything.vercel.app) | | Jun 27, 2024 8:47am |
golok727 commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @golok727 and the rest of your teammates on Graphite Graphite

L-Sun commented 1 week ago

Here is another problem about code block toolbar BS-660. May be it is solved by this PR? image

golok727 commented 1 week ago

@L-Sun I think the problem with ai panel is within AFFiNE. Its using the workspace container instead of the editor-host as context in the chat panel. Let's land this and fix it there! image

graphite-app[bot] commented 1 week ago

Merge activity