toeverything / blocksuite

🧩 Content editing tech stack for the web - BlockSuite is a toolkit for building editors and collaborative applications.
https://blocksuite.io
Mozilla Public License 2.0
4.37k stars 398 forks source link

feat: hide resize handles when dragging or resizing selected elements #7414

Closed pzppzz closed 3 months ago

pzppzz commented 3 months ago

for a better experience? hide all handles when dragging and hide all handles but the currently in use when resizing.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) Jun 25, 2024 7:14am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **blocksuite-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/toeverything/blocksuite-docs/CAQnodcXFJ2JW7yZZss9aH5ga76Y)) | [Visit Preview](https://blocksuite-docs-git-fork-pzppzz-feat-resize-25520d-toeverything.vercel.app) | | Jun 25, 2024 7:14am |
graphite-app[bot] commented 3 months ago

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

L-Sun commented 3 months ago

Cloud you provide a demo video showing the difference before and after the change?

pzppzz commented 3 months ago

Cloud you provide a demo video showing the difference before and after the change?

The effect is same as Canva.

before:

https://github.com/toeverything/blocksuite/assets/89590352/0c1b1c0b-f2c6-4fed-a68b-4c0cd4644c79

after:

https://github.com/toeverything/blocksuite/assets/89590352/d94a6d01-970e-4c1e-82f4-5c5961963dbb

L-Sun commented 3 months ago

@hwangdev97 what do you think? 🤔

golok727 commented 3 months ago

While moving elements works well, resizing should maintain the visibility of the handles, similar to Figma.

https://github.com/toeverything/blocksuite/assets/123532141/d45d4a49-cffc-4633-9359-b7a324824196