fix: scribbled style shape rendering

toeverything / blocksuite

🧩 Content editing tech stack for the web - BlockSuite is a toolkit for building editors and collaborative applications.

https://blocksuite.io

Mozilla Public License 2.0

4.09k stars 353 forks source link

Closed doouding closed 1 week ago

doouding commented 1 week ago

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2024 7:08am

1 Ignored Deployment

graphite-app[bot] commented 1 week ago

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

doouding commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite

Saul-Mirone commented 1 week ago

Maybe add e2e or integration test?

doouding commented 1 week ago

Maybe add e2e or integration test?

It's hard to assert if element is drawn in canvas or not. This can be done once the canvas-related test suite is configured.

graphite-app[bot] commented 1 week ago

Jun 27, 12:32 AM EDT: doouding added this pull request to the Graphite merge queue.
Jun 27, 12:40 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Playground E2E test (1)').
Jun 27, 3:06 AM EDT: doouding added this pull request to the Graphite merge queue.
Jun 27, 3:16 AM EDT: doouding merged this pull request with the Graphite merge queue.