fix(blocks): support azerty keyboard layout for slashmenu

toeverything / blocksuite

🧩 Content editing tech stack for the web - BlockSuite is a toolkit for building editors and collaborative applications.

https://blocksuite.io

Mozilla Public License 2.0

4.08k stars 352 forks source link

Closed L-Sun closed 5 days ago

L-Sun commented 6 days ago

Remove Shift in slash menu trigger detection.

According to https://en.wikipedia.org/wiki/Keyboard_layout, there are some keyboard layouts that require the Shift key to input a slash character.

This case can not be easily tested by playwright since keyboard layout managered by system.

Before (test AZERTY):

After (test QWERT and AZERTY):

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 29, 2024 4:16am

1 Ignored Deployment

graphite-app[bot] commented 6 days ago

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

L-Sun commented 6 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite