toeverything / blocksuite

🧩 Content editing tech stack for the web - BlockSuite is a toolkit for building editors and collaborative applications.
https://blocksuite.io
Mozilla Public License 2.0
4.08k stars 352 forks source link

feat(edgeless): support using last props for edgeless text #7476

Closed Flrande closed 1 day ago

Flrande commented 2 days ago

Support memory for style changes to edgeless text and optimize some naming in EditPropsStore.

Before:

https://github.com/toeverything/blocksuite/assets/50035259/cd9656c9-b79c-427a-98db-dc0484ec4295

After:

https://github.com/toeverything/blocksuite/assets/50035259/cbfb6c45-7768-4f73-9952-88714c25d89b

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 1:23pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **blocksuite-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/toeverything/blocksuite-docs/Eb5cPdY3WWsFJ6S51kVnDsL1bHH6)) | [Visit Preview](https://blocksuite-docs-git-flrande-featet-prop-0702-toeverything.vercel.app) | | Jul 3, 2024 1:23pm |
graphite-app[bot] commented 2 days ago

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Flrande commented 1 day ago

I think the previous API would be neater because calling the method in editPropsStore already implies the context.

I made this change because when I first used this API, I didn't know what the behaviours of record and apply were, nor did I understand what item and storage referred to. It was only after reading the original code that I figured out how to use it. Maybe we should separate storage and lastProps?🤔

doouding commented 1 day ago

I think the previous API would be neater because calling the method in editPropsStore already implies the context.

I made this change because when I first used this API, I didn't know what the behaviours of record and apply were, nor did I understand what item and storage referred to. It was only after reading the original code that I figured out how to use it. Maybe we should separate storage and lastProps?🤔

Fair enough, this justifies the change.

graphite-app[bot] commented 1 day ago

Merge activity