Closed Flrande closed 1 day ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
blocksuite | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 1:23pm |
Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
I think the previous API would be neater because calling the method in
editPropsStore
already implies the context.
I made this change because when I first used this API, I didn't know what the behaviours of record
and apply
were, nor did I understand what item
and storage
referred to. It was only after reading the original code that I figured out how to use it. Maybe we should separate storage
and lastProps
?🤔
I think the previous API would be neater because calling the method in
editPropsStore
already implies the context.I made this change because when I first used this API, I didn't know what the behaviours of
record
andapply
were, nor did I understand whatitem
andstorage
referred to. It was only after reading the original code that I figured out how to use it. Maybe we should separatestorage
andlastProps
?🤔
Fair enough, this justifies the change.
doouding
added this pull request to the Graphite merge queue.doouding
merged this pull request with the Graphite merge queue.
Support memory for style changes to edgeless text and optimize some naming in
EditPropsStore
.Before:
https://github.com/toeverything/blocksuite/assets/50035259/cd9656c9-b79c-427a-98db-dc0484ec4295
After:
https://github.com/toeverything/blocksuite/assets/50035259/cbfb6c45-7768-4f73-9952-88714c25d89b