search

tofaruk / oauth-php

Automatically exported from code.google.com/p/oauth-php
MIT License
0 stars 0 forks source link

OAuthRequester get the POST params of a wrong request #104

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm looking at this revision:

http://code.google.com/p/oauth-php/source/detail?r=102&path=/trunk/library/OAuth
Request.php

why exactly did you remove the "if (empty($uri))"?

This breaks stuff in the following way:

 - when we are receiving an OAuth request, and from that request do another OAuth request through OAuthRequester.
In the "inner" OAuth request, the parameters of the "outer" request get passed! 
That cannot be good...

can you explain?

Original issue reported on code.google.com by scherpenisse on 18 Mar 2011 at 11:34

GoogleCodeExporter commented 9 years ago 
This patch reinstates the `if empty($uri)` construct as a conditional before 
setting the values of the OAuthRequest to the current request, like it was 
before.

Original comment by scherpenisse on 22 Mar 2011 at 9:59

Attachments: