tofiqquadri / ngx-csv-parser

CSV Parser for Angular by Developers Hive
https://tofiqquadri.com/hire/connect
MIT License
25 stars 52 forks source link

Update to support Angular 15 #34

Closed thomasesh closed 1 year ago

thomasesh commented 1 year ago

Please update to support Angular 15

tofiqquadri commented 1 year ago

Doing it this Sunday.

thomasesh commented 1 year ago

Did you get a chance to do it?

Thanks so much for writing and maintaining this software.

tofiqquadri commented 1 year ago

@thomasesh can you share a sample Angular 15 application that you are using? I am trying to add some more features but it is taking time for me to do so, if you have something I can test it on more it would save me more time.

Email: tofiqquadri AT developershive DOT com

thomasesh commented 1 year ago

Sorry, but I don’t have a sample application. However, if you are able to release a beta version with angular 15 support, I could test my application with it and let you know the results.

Thanks Tom

thomasesh commented 1 year ago

Could you release just the Angular 15 update before adding new features? The new features could be released later..

Hoegsgaard commented 1 year ago

I would also really appreciate it if you could release the Angular 15 update first?

tofiqquadri commented 1 year ago

@Hoegsgaard @thomasesh working on it today.

tofiqquadri commented 1 year ago

@Hoegsgaard @thomasesh check the latest version of ngx-csv-parser 1.2.1 extending support for Angular 15

thomasesh commented 1 year ago

Thanks for the update. However, I think you forgot to update the projects/ngx-cvs-parser/package.json:

"peerDependencies": { "@angular/common": "^14.1.3", "@angular/core": "^14.1.3" }

I am still getting the following error from npm install:

npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"^14.1.3" from ngx-csv-parser@1.2.1 npm ERR! node_modules/ngx-csv-parser npm ERR! ngx-csv-parser@"^1.2.1" from the root project

tofiqquadri commented 1 year ago

@thomasesh can you check version 1.2.2 I have just added and update me if it works now?

tofiqquadri commented 1 year ago

@thomasesh can you verify if it works for you since it works fine for me? I'll consider this as done.