search

tofodroid / mimi-mod

Musical Instrument Minecraft Interface
MIT License
13 stars 4 forks source link

[BUG] Item frame scaling on contrabass and harp #122

Closed CaveNJ closed 4 months ago

CaveNJ commented 6 months ago

Describe the bug Contrabass and Harp have bugged item frame models

To Reproduce Place either item in an item frame

ALSO: Place the contrabass, it places down backwards. Every other block instrument places forwards.

Expected behavior It should be scaled the same as it appears in the hotbar relative to the item frame's boundaries.

Screenshots image

Environment (please complete the following information):

Additional context Frankly, both of these items need to be a lot bigger when placed

tofodroid commented 6 months ago

Huh, well that's definitely not right! 😆 I'll get that fixed for the current models, ASAP.

I just took a look at your other issue with those new models you made and they look fantastic! Much better than anything I'm capable of making so I'd definitely appreciate any other models you want to create!

tofodroid commented 5 months ago

A fix for the item frame issues (including fixes for several other block instruments) will be included in the 4.1.0 release which will be coming out soon!

Regarding the contrabass placing backwards - This is intentional as the instruments are placed down in the orientation that the player will sit at them when playing them and, unlike all of the other block instruments, when a musician is playing a contrabass they usually sit behind it:

4740533848_16b432ccf4_z

tofodroid commented 4 months ago

Version 4.1.0 has been release including this fix!